Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Insert Link" has no Language dropdown in SS 3.2 #214

Closed
JorisDebonnet opened this issue Dec 1, 2015 · 10 comments
Closed

"Insert Link" has no Language dropdown in SS 3.2 #214

JorisDebonnet opened this issue Dec 1, 2015 · 10 comments

Comments

@JorisDebonnet
Copy link
Contributor

The "Insert Link" dialog in the CMS does not show the "Language" dropdown above the "Pages" selector anymore, using Translatable 2.1.x-dev on SS 3.2.1 (also with 2.1.0 on 3.2.0). If I downgrade to 2.0.9 on SS 3.1.16, it DOES show the "Language" dropdown again.

What could be causing this? I guess it's somewhere in TranslatableCMSMainExtension?..

A client of mine just discovered this issue and it embarrasses me a bit that I can't fix it (without undoing my somewhat costly 3.1 => 3.2 upgrade) :s

@JorisDebonnet
Copy link
Contributor Author

Can anyone duplicate this issue please?

@tractorcow
Copy link
Contributor

Does the issue resolve itself when you upgrade to 3.2.1? I have a feeling it's due to a known issue that was resolved in that version.

@JorisDebonnet
Copy link
Contributor Author

3.2.1 is what I was using. I just tried with 3.2.x-dev (using composer, both framework and cms), but that does not make a difference (Translatable is already using 2.1.x-dev). The languages appear everywhere they should, except in the Insert Link dialog.

@tractorcow
Copy link
Contributor

Oh, darn, so not an easy fix as I'd hoped. :)

flxlabs pushed a commit to flxlabs/silverstripe-translatable that referenced this issue Feb 4, 2016
@flxlabs
Copy link

flxlabs commented Feb 4, 2016

I think that will do it: #222

@JorisDebonnet
Copy link
Contributor Author

Excellent, that fixes it indeed!

@JorisDebonnet
Copy link
Contributor Author

Could this fix be merged into 2.1 though? I see that it only made its way into master.

@JorisDebonnet JorisDebonnet reopened this Mar 9, 2016
@dhensby
Copy link
Contributor

dhensby commented Mar 9, 2016

done

@dhensby dhensby closed this as completed Mar 9, 2016
@jyrkij
Copy link

jyrkij commented Apr 25, 2016

Has this made its way to a released (tagged) version?

@dhensby
Copy link
Contributor

dhensby commented May 9, 2016

I'm afraid not - I was about to tag a fix but I can see a non-semver addition has been made and so that needs to be reverted...

What I'll probably do is merge 2.1 -> 2 and then release a 2.2 version. but I can't do it right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants