Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cacheKeyComponent used when locale filter is disabled #239

Closed
webtorque7 opened this issue Apr 3, 2016 · 2 comments
Closed

cacheKeyComponent used when locale filter is disabled #239

webtorque7 opened this issue Apr 3, 2016 · 2 comments

Comments

@webtorque7
Copy link

Should cacheKeyComponent still return something if filtering is disabled?

I have a case where a get_one is done with the locale filter on. ModelAsController is then failing to lookup the correct page because this result has been cached, even though ModelAsController disables the Translatable filter as the cache keys are the same.
@tractorcow
Copy link
Contributor

I think you're right... it should cache on some kind of "disabled-translatable" key if not filtering by a locale.

riddler7 pushed a commit to webtorque7/silverstripe-translatable that referenced this issue Apr 4, 2016
Fixes silverstripe#239, cacheKeyComponent updates cache key when filt…
07bd3c5 
…ering is disabled
tractorcow pushed a commit that referenced this issue Apr 4, 2016
Merge pull request #240 from webtorque7/cachekey
d4f064c 
Fixes #239, cacheKeyComponent updates cache key when filtering is disabled
@tractorcow
Copy link
Contributor

Fixed with #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tractorcow @webtorque7