FIX: PSR-2 codebase. Formatting via phpcbf #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase now |
NightJar
force-pushed
the
pulls/2.0/new-version-feed-v3
branch
from
90aaa14
to
40cc9b0
Compare
robbieaverill
approved these changes
Dec 11, 2017
robbieaverill
changed the title
|
Merge on green |
|
Ok so we should probably remove this logic and use the ORM: But for now let's update it to |
|
Yeah, there's a couple of blocks like that - the module is more heavily tied to SiteTree than I had first thought. Tests are probably passing locally because table names are case insensitive for me :/ |
FIX: PSR-2 codebase. Formatting via phpcbf FIX: rendering bug in allchanges FIX: update .gitattributes to not export codecov's config file FIX: Update SiteTree_versions to the ss4 equivalent SiteTree_Versions
NightJar
force-pushed
the
pulls/2.0/new-version-feed-v3
branch
from
3d80e07
to
67e112f
Compare
robbieaverill
approved these changes
Dec 12, 2017
|
Builds aren't quite there yet, but as this is a PSR-2 linting pull request I think we should merge it anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the code base to be PSR-2 compliant
Closes #43