Check module for SS4 compatibility #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raissanorth
force-pushed
the
pulls/2.0/update-to-ss4
branch
from
59a2bf5
to
de7473e
Compare
robbieaverill
suggested changes
Dec 18, 2017
lang/en.yml
Outdated
| PLURALNAME: 'Widget Areas' | ||
| SINGULARNAME: 'Widget Area' | ||
| WidgetAreaEditor_ss: | ||
| SilverStripe\Widgets\Templates\SilverStripe\Widgets\Forms\WidgetAreaEditor_ss: |
There was a problem hiding this comment.
These template pseudo namespaces need to be reverted to what they were so they match the <%t calls in the templates they reference :)
…update other langs
robbieaverill
approved these changes
Dec 19, 2017
This was referenced Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot reproduce issue "saving a page with new widgets redirects to 404" mentioned in the comments for #159 by using content-widget or blog module.