Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Enable Title to be CMS driven #84

Merged

Conversation

tractorcow
Copy link
Contributor

FIX issue with field scaffolding hiding the "Enabled" checkbox
FIX Safe escaping of CMSTitle / Description fields

In just about every widget it's necessary to add a custom CMS field to set the title, so this has been put in core.

I would possibly suggest merging this AFTER #83, and making a new branch prior to the merge in order to maintain backwards compatibility. 1.0 being the branch without CMS title (as it exists) and master (aliased as 1.1) could have the new feature.

FIX issue with field scaffolding hiding the "Enabled" checkbox
FIX Safe escaping of CMSTitle / Description fields
@tractorcow
Copy link
Contributor Author

I've rebased from #83 and updated the master alias to 1.1.
Note the creation of the 1.0 branch for backwards compatibility. :)

assertchris added a commit that referenced this pull request Mar 6, 2015
@assertchris assertchris merged commit 59e4ba5 into silverstripe:master Mar 6, 2015
@tractorcow tractorcow deleted the pulls/api-customise-title branch March 6, 2015 02:50
@tractorcow
Copy link
Contributor Author

Ta :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants