BUGFIX: Fixed issue where Widget::CMSEditor() can't rename the enabled checkbox #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure looks unrelated (but should still be looked into). Thanks Ed. |
wilr
added a commit
that referenced
this pull request
Apr 2, 2015
BUGFIX: Fixed issue where Widget::CMSEditor() can't rename the enabled checkbox
|
I'll see if I can do up a pull request for that too seems pretty simple looks like a couple of deprecation warnings for some legacy calls to DataObject::get* |
|
This was actually fixed in master (now 1.1 branch) fyi :D It's still good to fix it here too though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a widget the Enabled checkbox is present in the form but it does not get renamed by Widget::CMSEditor() since it is nested in a tabset. This causes the enabled checkbox be hidden after saving the widget for the first time. Oddly this also unchecks the checkbox, so the next time the holder page/object its saved the widget becomes disabled and no longer shows on the front end.