Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the default export test for IPv4 or IPv6 #1

Closed
silverwind opened this issue Dec 3, 2017 · 3 comments
Closed

Have the default export test for IPv4 or IPv6 #1

silverwind opened this issue Dec 3, 2017 · 3 comments

Comments

@silverwind
Copy link
Owner

I think that instead of assigning the default export to isCidrV4, I'd make more sense to check if the given value is either IPv4 or IPv6, e.g. isCidrV4(input) || isCidrV6(input).

@iarna
Copy link

iarna commented Dec 17, 2017

That seems like a reasonable default. (But please bump the major if you do that!)

@flipjs
Copy link
Collaborator

flipjs commented Dec 17, 2017

I agree with you @iarna . This is a breaking change so it should be a major bump.

@silverwind
Copy link
Owner Author

Yes, of course, I will update both cidr-regex and is-cidr and then release new major versions.

silverwind added a commit that referenced this issue Dec 18, 2017
silverwind added a commit that referenced this issue Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants