Skip to content

Commit

Permalink
automated weekly data update
Browse files Browse the repository at this point in the history
  • Loading branch information
@silverwind
silverwind committed May 18, 2019
1 parent 9afeac1 commit a5962b8
Show file tree
Hide file tree
Showing 2 changed files with 662 additions and 621 deletions.

4 comments on commit a5962b8

@theboolean
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silverwind first of all thanks for this library.
I noticed that the last commit fixed the encoding error of some strings, but in this commit they are back (you can notice the ? where there should be an accented character). Maybe something isn't working properly?

@silverwind
Copy link
Owner Author

@silverwind silverwind commented on a5962b8 May 22, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings come like this from the linuxnet source. Apparently they (or the IEEE) changed something about those non-ASCII characters but there's nothing I can do about it except switching to the IEEE source which had even more such encoding issues last I checked.

@theboolean
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification

@silverwind
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #11 about it.

Please sign in to comment.