Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get pixels relative to x1 and y1 on source image #100

Merged
merged 1 commit into from Jun 30, 2021

Conversation

bboshoven
Copy link

Currently the cropping behaviour always starts at x1 = 0, y1 = 0 on the source image. This should fix that.

@silvia-odwyer
Copy link
Owner

@bboshoven Thanks for fixing this, much appreciated! 😄 I'm going to merge this now 👍

@silvia-odwyer silvia-odwyer merged commit 35adb2c into silvia-odwyer:master Jun 30, 2021
@azarashill
Copy link

When will this branch merged into photon-node?

@silvia-odwyer
Copy link
Owner

silvia-odwyer commented Jan 24, 2022

Hi @azarashill 😄 During the next release of the library, the photon-node NPM package will then be updated. However that being said, if you require this functionality earlier, you could clone the repo and build the library for Node by running wasm-pack build --target nodejs
Hope that helps! 👍

@azarashill
Copy link

@silvia-odwyer thanks for a lot!

@nathanbabcock
Copy link
Contributor

This fix never made it onto the published crate, right? The commit is dated June 2021, and the last published version is from April 2021. Any ETA on the next release?

Great lib btw :)

@silvia-odwyer
Copy link
Owner

@nathanbabcock Hi Nathan! I'm planning to add some extra filters to the library, and will be releasing a new version of the library quite soon, hopefully in the next few weeks or so. 😄 It'll be great to have the new features from the library's various contributors added to the published crate too :D

@nathanbabcock
Copy link
Contributor

@silvia-odwyer Thanks Silvia, that's great news. 😀 Using Photon I was able to add WASM/browser support to the computer vision library I'm working on. I use it for preprocessing images before doing text or image recognition on them. I'll definitely use the newest version of Photon when it comes out. Cheers! 🍻

@silvia-odwyer
Copy link
Owner

@nathanbabcock Hi Nathan, I recently published a new version of Photon on crates.io, which includes the updated cropping function. It's part of the 0.3.2 release, which is now available.
Hypetrigger looks fantastic by the way, and it's very exciting to see WASM support added to this also! ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants