Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing from git #18

Closed
isik-kaplan opened this issue Jul 20, 2019 · 1 comment
Closed

Installing from git #18

isik-kaplan opened this issue Jul 20, 2019 · 1 comment
Assignees

Comments

@isik-kaplan
Copy link

Hi there,

After seeing that #10 is closed, I wanted to install it from directly git since it has not been yet released to pypi and realized that I can't, because setup.py tries to catch RuntimeError instead of ModuleNotFoundError,

django-pwa/setup.py

Lines 8 to 14 in 6ba2817

try:
# noinspection PyPackageRequirements
import pypandoc
long_description = pypandoc.convert('README.md', 'rst')
except RuntimeError:
long_description = short_description
which is not a subclass of RuntimeError, when importing pypandoc. I think this is a mistake since descriptions are not all that important(I think) for the actual installation of the library.

Also, I'd love to learn if you are planning a new release.

Thanks!

yasakawa pushed a commit to yasakawa/django-pwa that referenced this issue Aug 30, 2019
@silviolleite silviolleite self-assigned this Dec 8, 2019
@silviolleite
Copy link
Owner

Done! It was fixed! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants