Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL inclusion #35

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

Natureshadow
Copy link
Contributor

Closes #34.

@codecov-io
Copy link

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          47     49    +2     
=====================================
+ Hits           47     49    +2
Impacted Files Coverage Δ
pwa/app_settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c36673...67cf917. Read the comment docs.

@Natureshadow
Copy link
Contributor Author

@silviolleite Anything keeping this fix from being merged :)?

Copy link
Owner

@silviolleite silviolleite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silviolleite silviolleite merged commit 61cdbf6 into silviolleite:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including django-pwa URLs in root urlconf broken in 1.0.7
3 participants