Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sizes property name to size in README #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sizes property name to size in README #80

wants to merge 1 commit into from

Conversation

PetrDlouhy
Copy link

Fix #38
The sizes property name in README doesn't match with the code, where is it named size:

django-pwa/pwa/templates/pwa.html

Line 19 in 0ff60e7

<link rel="apple-touch-icon" href="{{ icon.src }}" sizes="{{ icon.size }}">

@JelleBootsma
Copy link
Contributor

I believe this should be fixed in pwa.html, instead of in the readme. The icon property should be called sizes, as this also injected into the manifest.json and here it should be sizes, as can be seen on MDN Web Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sizes not in html
2 participants
@PetrDlouhy @JelleBootsma