Blog demo redirect problem, UrlFor(THome) returns empty string #2

leledumbo · 2012-12-29T07:50:17Z

I convert the blog demo into fastcgi project, replacing hardcoded link in the form action of newpost.html template into /post/. The problem is after I press the post button, I got empty page. The data does get in to the database though. Quick investigation shows that this piece of code:

procedure TPost.Post;
begin
  Table.Insert(Fields).Apply;
  Redirect(UrlFor(THome), BROOK_HTTP_STATUS_CODE_FOUND);
end;

cause the problem because UrlFor(THome) returns empty string.

silvioprog · 2012-12-31T18:21:01Z

UrlFor depends of TRequest.PathInfo, and it must return the current PATH_INFO. Can you execute the test below?:

procedure TMyAction.Request(ARequest: TRequest; AResponse: TResponse);
begin
  Write(ARequest.PathInfo);
end;

initialization
  TMyAction.Register('/a/b'); // call http://localhost/cgi-bin/cgi1/a/b

If you not got /a/b on the browser, the problem is in FCL-Web for FastCGI.

leledumbo · 2013-01-01T03:50:20Z

Yes, I do get /a/b on the browser. THome is registered with '*' pattern (and is set as default), would that be the problem? Since the pathinfo will be / (tested and proven), even if I give a non-existent path (because it's set as default).

silvioprog · 2013-01-01T06:30:05Z

The 'problem' is in the FCL-Web for FastCGI. Using this code below:

procedure TMyAction.Request(ARequest: TRequest; AResponse: TResponse);
begin
  Write(GetEnvironmentVariable('SCRIPT_NAME'));
end;

compiled for CGI and calling http://localhost/cgi-bin/cgi1, the result is: /cgi-bin/cgi1. But, compiled for FastCGI and calling http://localhost/cgi-bin/cgi1, the result is empty.

So the problem isnt in Brook. :/ Open a entry in Free Pascal bugtracker?

leledumbo · 2013-01-01T08:33:13Z

OK, but actually I don't know what's wrong with that. I mean, should SCRIPT_NAME be equal for both?

silvioprog · 2013-01-01T18:42:52Z

I don't think so. :(
Please see: http://www.fastcgi.com/devkit/doc/fcgi-spec.html

leledumbo · 2013-01-03T12:32:55Z

I'm still not sure what to report to FPC mantis (my brain has a problem reading specs :p), could you do that instead?

silvioprog · 2013-01-04T02:15:22Z

I do not feel safe to report this due to limitation of my English. XD
So, what will we do hehehe?

It would be interesting to test a small FastCGI script in another programming language (Perl?) and check if it returns this variable.

silvioprog · 2013-01-04T02:27:00Z

Oh god, Perl FCGI return the SCRIPT_NAME, please see:

http://brookframework.org/test.fbf

Response:

FastCGI Demo Page (perl)

This is coming from a FastCGI server. 
Running on brookframework.org - /test.fbf to XXX
This is connection number 1

The code of this test:

#!/usr/bin/perl -wT

use strict;
use vars qw( $cnt );
use FCGI;

local $cnt = 0;

while ( FCGI::accept >= 0 ) {
  print "Content-type: text/html\r\n\r\n";
  print "<head>\n<title>FastCGI Demo Page (perl)</title>\n</head>\n";
  print  "<h1>FastCGI Demo Page (perl)</h1>\n";
  print "This is coming from a FastCGI server.\n<BR>\n";
  print "Running on <EM>$ENV{SERVER_NAME}-$ENV{SCRIPT_NAME}</EM> to <EM>$ENV{REMOTE_HOST}</EM>\n<BR>\n";
   $cnt++;
  print "This is connection number $cnt\n";
}

leledumbo · 2013-01-04T06:11:32Z

Perhaps this report is enough: SCRIPT_NAME in a FastCGI application returns empty string. What do you think?

silvioprog · 2013-01-04T06:14:11Z

Perfect! Send me the issue link after you submit.

leledumbo · 2013-01-04T15:55:24Z

Could you try this first on Apache? In my Nginx, I don't even find SCRIPT_NAME at all...

silvioprog · 2013-01-07T05:10:53Z

Yes:

http://brookframework.org/project1.fbf

But if I'm not mistaken, the FastCGI not read the informations directly from the environment variables.

But in my mind there is way to solve this easily: BrookSettings.RootUrl. By default this property is filled by SCRIPT_NAME value. It seems a good idea? :)

silvioprog · 2013-01-07T14:40:44Z

This will be implemented as soon as possible. :)

ps. Oh, sorry friend, I accidentally deleted your comment, but I pasted it below (copied from my Gmail). x(

2013/1/7 Mario Ray Mahardhika says:

But if I'm not mistaken, the FastCGI not read the informations directly
from the environment variables.

I'll ask Michael to ensure.

But in my mind there is way to solve this easily: BrookSettings.RootUrl.
By default this property is filled by SCRIPT_NAME value. It seems a good
idea? :)

Filled automatically on each request? Seems good.

silvioprog · 2013-01-17T18:43:04Z

Hello Mario,

Done (685a03e).

Can you test it please?

Thanks! :)

silvioprog · 2013-01-17T18:46:22Z

I implemented it in "working" branch (http://imagebin.org/243220).

leledumbo · 2013-01-18T11:41:39Z

Tested and works, the documentation needs to be expanded though. It should say that RootURL must be filled in order for Redirect (or UrlFor) to work

silvioprog · 2013-01-18T14:53:13Z

Guy, more adjusts: cb3fcb4

Can you help me to add more details on documentation? My translator is still on vacation hehehe...

silvioprog · 2013-01-20T06:07:37Z

Nice?:

(...)
    { Set the default root URL. This is used by methods such as
      @code(TBrookAction.UrlFor), @code(TBrookActionHelper.LinkTo),
      @code(TBrookActionHelper.ButtonTo) etc. By default, Brook assumes
      @code(SCRIPT_NAME) as root URL. }
    RootUrl: string;
(...)

leledumbo · 2013-01-20T06:15:37Z

By default, Brook assumes @code(SCRIPT_NAME) as root URL

Just to be sure, which code fills this field when it's empty?

silvioprog · 2013-01-20T06:19:07Z

In the router:

1 - https://github.com/silvioprog/brookframework/blob/master/core/brookrouter.pas#L360
2 - https://github.com/silvioprog/brookframework/blob/master/core/brookrouter.pas#L368

silvioprog · 2013-01-20T07:27:48Z

The new "pasdoc comment" for documentation is good?

leledumbo · 2013-01-20T16:56:55Z

OK, then it's good.

silvioprog · 2013-01-20T17:07:55Z

Done (538afb4). Thank you friend!

leledumbo mentioned this issue Dec 31, 2012

Can't handle a lot of requests #8

Closed

silvioprog added a commit that referenced this issue Jan 17, 2013

# Please see issue #2 (#2).

685a03e

silvioprog added a commit that referenced this issue Jan 20, 2013

# Please see issue #2 (#2).

538afb4

silvioprog closed this as completed Jan 20, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blog demo redirect problem, UrlFor(THome) returns empty string #2

Blog demo redirect problem, UrlFor(THome) returns empty string #2

leledumbo commented Dec 29, 2012

silvioprog commented Dec 31, 2012

leledumbo commented Jan 1, 2013

silvioprog commented Jan 1, 2013

leledumbo commented Jan 1, 2013

silvioprog commented Jan 1, 2013

leledumbo commented Jan 3, 2013

silvioprog commented Jan 4, 2013

silvioprog commented Jan 4, 2013

leledumbo commented Jan 4, 2013

silvioprog commented Jan 4, 2013

leledumbo commented Jan 4, 2013

silvioprog commented Jan 7, 2013

silvioprog commented Jan 7, 2013

silvioprog commented Jan 17, 2013

silvioprog commented Jan 17, 2013

leledumbo commented Jan 18, 2013

silvioprog commented Jan 18, 2013

silvioprog commented Jan 20, 2013

leledumbo commented Jan 20, 2013

silvioprog commented Jan 20, 2013

silvioprog commented Jan 20, 2013

leledumbo commented Jan 20, 2013

silvioprog commented Jan 20, 2013

Blog demo redirect problem, UrlFor(THome) returns empty string #2

Blog demo redirect problem, UrlFor(THome) returns empty string #2

Comments

leledumbo commented Dec 29, 2012

silvioprog commented Dec 31, 2012

leledumbo commented Jan 1, 2013

silvioprog commented Jan 1, 2013

leledumbo commented Jan 1, 2013

silvioprog commented Jan 1, 2013

leledumbo commented Jan 3, 2013

silvioprog commented Jan 4, 2013

silvioprog commented Jan 4, 2013

leledumbo commented Jan 4, 2013

silvioprog commented Jan 4, 2013

leledumbo commented Jan 4, 2013

silvioprog commented Jan 7, 2013

silvioprog commented Jan 7, 2013

silvioprog commented Jan 17, 2013

silvioprog commented Jan 17, 2013

leledumbo commented Jan 18, 2013

silvioprog commented Jan 18, 2013

silvioprog commented Jan 20, 2013

leledumbo commented Jan 20, 2013

silvioprog commented Jan 20, 2013

silvioprog commented Jan 20, 2013

leledumbo commented Jan 20, 2013

silvioprog commented Jan 20, 2013