fix: avoid assigning partitions if consumer is not running #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing. you are right regarding the fix ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We are having some problems when trying to stop multiple clients of the same consumer group concurrently. We have seen that in some occasions, we are receiving partition assignment requests (I guess due to rebalancing when stopping another client) on clients that already have the running flag set to false. This is preventing the client from being completely stopped (and I think generating a deadlock by not releasing all the rd_kafka objects).
I have included a check in the assignment method to verify that the client is not running (same mechanism as in the revoke partitions function).