Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails with numpy 1.19.0rc* #389

Closed
t20100 opened this issue Jun 2, 2020 · 9 comments
Closed

Test fails with numpy 1.19.0rc* #389

t20100 opened this issue Jun 2, 2020 · 9 comments
Assignees
Labels

Comments

@t20100
Copy link
Member

t20100 commented Jun 2, 2020

Weekly CI test fails (see below), it started to fails with pre-release of numpy v1.19.0rc1 (see https://gitlab.esrf.fr/silx/bob/fabio/pipelines/26203) and is still broken with v1.19.0rc2 (see https://gitlab.esrf.fr/silx/bob/fabio/pipelines/26562):

197 ======================================================================
198 FAIL: test_linear (fabio.test.codecs.test_brukerimage.TestBrukerLinear)
199 test for self consistency of random data read/write
200 ----------------------------------------------------------------------
201 Traceback (most recent call last):
202   File "/opt/python/cp36-cp36m/lib/python3.6/site-packages/fabio/test/codecs/test_brukerimage.py", line 155, in test_linear
203     self.assertTrue(error < numpy.finfo(numpy.float32).eps, "Error is %s>1e-7" % error)
204 AssertionError: False is not true : Error is 0.99999654>1e-7
205 ----------------------------------------------------------------------
@vallsv
Copy link
Contributor

vallsv commented Jun 2, 2020

It looks like there is also a huge incompatibility between python 3.5 and setuptools.

https://gitlab.esrf.fr/silx/bob/fabio/-/jobs/106973

@t20100
Copy link
Member Author

t20100 commented Jun 2, 2020

numpy 1.19.0* no longer supports python 3.5 (https://github.com/numpy/numpy/releases)

@vallsv
Copy link
Contributor

vallsv commented Jun 2, 2020

So there is bug in there pipy dependencies? Or that's on our side?

@vallsv
Copy link
Contributor

vallsv commented Jun 2, 2020

Iv checked there side, there is the right flags. No Python 3.5 on the metadata.

@t20100
Copy link
Member Author

t20100 commented Jun 2, 2020

I fixed the python3.5 in weekly CI by only installing from binary, but the issue reported here remains...

@kif
Copy link
Member

kif commented Jun 3, 2020

So there are 2 issues:

  • numpy 1.19 dropped python 3.5 (exit debian9)
  • fabio test suite failing with numpy 1.19 for python 3.6

@kif kif self-assigned this Jun 3, 2020
@kif kif added the bug label Jun 3, 2020
@kif
Copy link
Member

kif commented Jun 3, 2020

I managed to reproduce the bug on python 3.7: still test_brukerimage

@kif
Copy link
Member

kif commented Jun 3, 2020

The error is probably in the writing as the data are empty.

@kif
Copy link
Member

kif commented Jun 3, 2020

The issue is that float32 is not a subtype of float anymore (was a bug)

@vallsv vallsv closed this as completed in d492323 Jun 3, 2020
vallsv added a commit that referenced this issue Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants