Recognizing a Global Header Section and using it as default #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update files in boesecke/fabio/master with silx-kit/fabio/master
Include recent updates
that are starting with the key EDF_DataFormatVersion. Using general header contents as default for all frames.
…l header. Checking that general header keys are included as default in all frames.
The master branch was previously merged with the silx/fabio branch.
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Global Header Section (general block) is the one that starts with the keyword EDF_DataFormatVersion, otherwise no Global Header Section is defined for the opened file. Its contents is used as default for all frames. Checks have been added in test_edfimage1.py for verifying the correct reading of these type of files and for verifying that a keyword of the general block is really used as default in data frame headers.
(originally, "VersionNumber" was defined for this purpose. Because it could be located somewhere inside the header it would require reading the full header. This is time consuming and has been abandoned.)