Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server extension using h5grove to replace jupyterlab_hdf #40

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Add server extension using h5grove to replace jupyterlab_hdf #40

merged 1 commit into from
Jun 24, 2021
+201 −40

Conversation

loichuder
Copy link
Member

@loichuder loichuder commented Jun 22, 2021 •
edited
Loading

Also:

  • Update h5web to 0.0.23 (needed for H5CoreProvider, alias to H5GroveProvider to match the project renaming)
  • H5Web widgets resolve file paths according to notebook location (was JupyterLab server location before)

@loichuder loichuder changed the title Add server extension using h5core to replace jupyterlab_hdf Add server extension using h5grove to replace jupyterlab_hdf Jun 22, 2021
@loichuder loichuder force-pushed the back-end branch 3 times, most recently from ab66330 to edb6766 Compare June 22, 2021 11:56
@loichuder loichuder requested review from axelboc and t20100 June 22, 2021 11:58
t20100
t20100 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a few comments/suggestions.

A few docstring here and there could help.

jupyterlab_h5web/__init__.py Outdated Show resolved Hide resolved
jupyterlab_h5web/__init__.py Show resolved Hide resolved
jupyterlab_h5web/utils.py Outdated Show resolved Hide resolved
jupyterlab_h5web/utils.py Outdated Show resolved Hide resolved
@loichuder loichuder requested a review from t20100 June 23, 2021 13:17
@t20100
Copy link
Member

t20100 commented Jun 24, 2021

Nice!

@loichuder loichuder merged commit 023c175 into main Jun 24, 2021
@loichuder loichuder deleted the back-end branch June 24, 2021 08:29
This was referenced Jun 24, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t20100 t20100 t20100 approved these changes

@axelboc axelboc Awaiting requested review from axelboc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loichuder @t20100