Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silx: Uses old name of sip module #3170

Closed
picca opened this issue Aug 4, 2020 · 3 comments
Closed

silx: Uses old name of sip module #3170

picca opened this issue Aug 4, 2020 · 3 comments

Comments

@picca
Copy link
Contributor

picca commented Aug 4, 2020

Hello, guyes,

I am preparing the 0.13.1. version for Debian/Ubuntu/...

I got this bug report https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966051

cheers

Fred
@vasole
Copy link
Member

vasole commented Aug 4, 2020

That import only takes places if PyQt5 cannot be imported. If PyQt4 is dropped it is not needed.

Is that bug report an "automatic" finding or somebody has actually fallen into that "leftover"?

@vasole
Copy link
Member

vasole commented Aug 4, 2020

Please note that if one uses PyQt4 the correct import is "import sip" and obviously not "import PyQt5.sip"

@t20100
Copy link
Member

t20100 commented Aug 25, 2020

Hi,

Double checking it, import sip should not occur if PyQt5 is available.
Nothing we can do until we drop PyQt4 support (already deprecated for a year).

I'm closing it, please reopen if needed.

@t20100 t20100 closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@picca @vasole @t20100