Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build under windows. #10

Merged
merged 2 commits into from Mar 5, 2016
Merged

Allow build under windows. #10

merged 2 commits into from Mar 5, 2016

Conversation

vasole
Copy link
Member

@vasole vasole commented Mar 5, 2016

Addresses #9

PiRK pushed a commit that referenced this pull request Mar 5, 2016
Allow build under windows.
@PiRK PiRK merged commit c04438d into silx-kit:master Mar 5, 2016
@kif
Copy link
Member

kif commented Mar 6, 2016

2 comments:

  1. one should probably use "os.path.dirname(os.path.abspath(file) )" instead of "os.path.dirname(file)", especially in setup.py which under certain circumstances results in "".
  2. this "urgent pull request" highlights the lack of test for the given feature. The continuous integration tool did not spot it.

@vasole
Copy link
Member Author

vasole commented Mar 6, 2016

On 06.03.2016 09:40, Jerome Kieffer wrote:

2 comments:

one should probably use "os.path.dirname(os.path.abspath(FILE) )"
instead of "os.path.dirname(FILE)", especially in setup.py which under
certain circumstances results in "".

  • Yes

this "urgent pull request" highlights the lack of test for the given
feature. The continuous integration tool did not spot it.

Things to be solved {are they worth a specific issue?):

  • How can we test build without Cython besides build without Cython? Can
    we specify two builds?
  • Same as above but running the build of the sources generated with
    sdist.

@vasole
Copy link
Member Author

vasole commented Mar 6, 2016

  • If possible, I would aim for the continuous integration tests to be run on the sources generated by sdist and not on a repository copy.
  • I guess the build from the git sources is tested almost every day :-)

@t20100 t20100 mentioned this pull request Mar 7, 2016
2 tasks
@t20100
Copy link
Member

t20100 commented Mar 7, 2016

+1 for test from sdist and without Cython in at least 1 CI.
See issue #12

vallsv added a commit that referenced this pull request Aug 2, 2017
vallsv pushed a commit that referenced this pull request Sep 11, 2017
I do like.
It was already the case on my system without this call, but it is most probably system dependent, thanks.
t20100 pushed a commit that referenced this pull request Oct 26, 2017
t20100 pushed a commit that referenced this pull request May 16, 2019
Add support of is|setVisible RegionOfInterestTableWidget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants