Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx view: Set max number of opened file at start-up #3545

Merged
merged 1 commit into from Nov 4, 2021

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Nov 3, 2021

This PR set the max number of opened files at silx view start-up to mitigate issue of too many file descriptors opened.

It's been successfully tested on the file from issue #3537 under linux.
It still needs to be tested on Windows and macos to check that the fix does not create errors on those OS.

closes #3537

@t20100 t20100 added this to the 1.0.0 milestone Nov 3, 2021
@t20100 t20100 marked this pull request as ready for review November 4, 2021 09:14
@t20100
Copy link
Member Author

t20100 commented Nov 4, 2021

Tested on Windows and macOS, ready for review.

There is an issue with PySide2 on Windows in CI that set fault at the end of tests on all recent PRs.

@t20100 t20100 requested a review from payno November 4, 2021 09:16
Copy link
Member

@payno payno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@payno payno merged commit 895b171 into silx-kit:master Nov 4, 2021
@t20100 t20100 deleted the silx-view-ulimit branch November 5, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

silx view: AttributeError error when opening a group containing external links
2 participants