Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventless OpenCL profiling #3690

Merged
merged 12 commits into from
Oct 10, 2022
Merged

Conversation

kif
Copy link
Member

@kif kif commented Oct 6, 2022

A memory leak was found when keeping all events from PyOpenCL for profiling purposes.
inducer/pyopencl#625

This PR extracts earlier the timing info to avoid keeping references on input buffers.

Changelog:
New OpenCL profiling (fix memory leak)

Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, find a small typo in the namedtuple naming

src/silx/opencl/processing.py Outdated Show resolved Hide resolved
src/silx/opencl/processing.py Outdated Show resolved Hide resolved
src/silx/opencl/processing.py Outdated Show resolved Hide resolved
src/silx/opencl/processing.py Outdated Show resolved Hide resolved
src/silx/opencl/processing.py Outdated Show resolved Hide resolved
kif and others added 5 commits October 6, 2022 17:46
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
Co-authored-by: Thomas VINCENT <thomas.vincent@esrf.fr>
@pierrepaleo pierrepaleo merged commit 96d8f1a into silx-kit:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants