Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectoh5 #78

Merged
merged 3 commits into from
May 18, 2016
Merged

Spectoh5 #78

merged 3 commits into from
May 18, 2016

Conversation

PiRK
Copy link
Member

@PiRK PiRK commented May 18, 2016

Closes #77 (bug attributes not created when creating groups or datasets when converting SpecFile to HDF5)

Minor documentation improvements.

@PiRK
Copy link
Member Author

PiRK commented May 18, 2016

Regarding our discussion about enforcing ascii when writing attribute values, I believe ASCII encoding is implicitly done by my usage of numpy.string_, as all my attributes use only basic alphabetical characters without accents.

FYI, attributes are defined here: https://github.com/PiRK/silx/blob/master/silx/io/spech5.py#L294

@t20100 t20100 merged commit 08496e8 into silx-kit:master May 18, 2016
@PiRK PiRK deleted the spectoh5 branch July 8, 2016 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants