Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code editor for 'Additional JSON Data ' is not show #24

Closed
sospartan opened this issue Dec 11, 2018 · 8 comments
Closed

Code editor for 'Additional JSON Data ' is not show #24

sospartan opened this issue Dec 11, 2018 · 8 comments
Labels
bug Something isn't working

Comments

@sospartan
Copy link

I'm using grafana 5.0.0 and simpod-json-datasource 0.1.0
The editor is not display when click the 'Additional JSON Data' link.

Found some error in console:

angular.js:14794 TypeError: Cannot read property 'match' of null
    at u.$detectNewLine (index.js:6626)
    at u.insert (index.js:6698)
    at u.setValue (index.js:6606)
    at b.setValue (index.js:11971)
    at r (code_editor.ts:177)
    at Object.r [as link] (app.b0d4f36bb5b6bb18e2ab.js:13493)
    at angular.js:1383
    at angular.js:10605
    at Mt (angular.js:10611)
    at d (angular.js:10000) "<code-editor content="ctrl.target.data" data-mode="json" on-change="ctrl.onChangeInternal()" data-max-lines="30" class=" ace_editor ace-tm">"
@sospartan
Copy link
Author

ping @simPod

@simPod
Copy link
Owner

simPod commented Dec 13, 2018

I cannot reproduce the issue (I'm on grafana 5.3 though).

Try upgrading and if the problem persists, try to debug what's causing the issue. Thanks!

@sospartan
Copy link
Author

😢 I know nothing about TS or angular. Hope upgrading will fix this. 🙏

@simPod
Copy link
Owner

simPod commented Dec 13, 2018

Placing several console.logs around the place where the error is thrown might bring some light into this eventually. No need for TS or angular (yet 😉 ). I suppose the debugging will first have to be made in grafana's code, not this plugin's.

@zak-b2c2
Copy link

He is not wrong, it happened to me when I updated the git repo.
But if I roll-back using git reset --hard f965b58, it works fine. And on a clean install using grafana-cli, it also does not work...

@OloloevReal
Copy link

The same problem

Data source query result invalid, missing data field: [] query_ctrl.ts:25 timeseries angular.js:14700 TypeError: Cannot read property 'match' of null at u.$detectNewLine (index.js:6626) at u.insert (index.js:6698) at u.setValue (index.js:6606) at b.setValue (index.js:11971) at m (code_editor.ts:126) at Object.tt [as link] (code_editor.ts:122) at angular.js:1385 at angular.js:10539 at Re (angular.js:10545) at ie (angular.js:9934) "<code-editor content="ctrl.target.data" data-mode="json" on-change="ctrl.onChangeInternal()" data-max-lines="30" class=" ace_editor gf-code-dark ace_dark">" 

@simPod simPod added the bug Something isn't working label Dec 13, 2018
@simPod
Copy link
Owner

simPod commented Dec 13, 2018

You're right, I was able to reproduce.

simPod added a commit that referenced this issue Dec 13, 2018
@simPod simPod mentioned this issue Dec 13, 2018
@andig andig closed this as completed in #25 Dec 14, 2018
andig pushed a commit that referenced this issue Dec 14, 2018
* Fix empty data

Fixes #24

* Release v0.1.1
@simPod
Copy link
Owner

simPod commented Dec 14, 2018

You can subscribe here to see when upgrade is released

grafana/grafana-plugin-repository#345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants