tmp remove batchFirst

simPod · Jul 6, 2020 · 6266703 · 6266703
1 parent ea57eef
commit 6266703
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 38 deletions.
diff --git a/src/Helpers/ValueGetter.php b/src/Helpers/ValueGetter.php
@@ -14,38 +14,19 @@
 final class ValueGetter
 {
     /**
-     * @param array<string, mixed> $response
+     * @param array<int|string, mixed> $response
      *
      * @return mixed
      *
      * @psalm-template T
-     * @psalm-param array<string, T> $response
+     * @psalm-param array<int|string, T> $response
      * @psalm-return T
      */
     public static function first(array $response)
     {
-        return self::batchFirst([$response])[0];
-    }
-
-    /**
-     * @param list<array<string, mixed>> $responses
-     *
-     * @return list<mixed>
-     *
-     * @psalm-template T
-     * @psalm-param list<array<string, T>> $responses
-     * @psalm-return list<T>
-     */
-    public static function batchFirst(array $responses) : array
-    {
-        $result = [];
-        foreach ($responses as $response) {
-            $first = array_shift($response);
-            if ($first === null) {
-                throw GeneralException::new('Expected non-empty array');
-            }
-
-            $result[] = $first;
+        $result = array_shift($response);
+        if ($result === null) {
+            throw GeneralException::new('Expected non-empty array');
         }
 
         return $result;

diff --git a/tests/Helpers/ValueGetterTest.php b/tests/Helpers/ValueGetterTest.php
@@ -26,20 +26,6 @@ public function testFirstWithUnexpectedData() : void
         ValueGetter::first([]);
     }
 
-    public function testBatchFirst() : void
-    {
-        $responses = [['.1.2.3.1' => 'a'], ['.3.4.5.1' => 'b']];
-
-        self::assertSame(['a', 'b'], ValueGetter::batchFirst($responses));
-    }
-
-    public function testBatchFirstWithUnexpectedData() : void
-    {
-        $this->expectExceptionObject(GeneralException::new('Expected non-empty array'));
-
-        ValueGetter::batchFirst([[]]);
-    }
-
     public function testFirstFromSameTree() : void
     {
         $snmpClient = $this->createMock(SnmpClient::class);