Skip to content

Commit

Permalink
Revert "feat: add type to promise (#216)" (#227)
Browse files Browse the repository at this point in the history
This reverts commit 6fb8abb.
  • Loading branch information
simPod committed Jan 12, 2024
1 parent f650ddb commit bafdbbf
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
10 changes: 0 additions & 10 deletions phpstan-baseline.neon
@@ -1,15 +1,5 @@
parameters:
ignoreErrors:
-
message: "#^Parameter \\#2 \\$next \\(callable\\(Psr\\\\Http\\\\Message\\\\RequestInterface\\)\\: Http\\\\Promise\\\\Promise\\<Psr\\\\Http\\\\Message\\\\ResponseInterface\\>\\) of method SimPod\\\\ClickHouseClient\\\\Client\\\\Http\\\\LoggerPlugin\\:\\:handleRequest\\(\\) should be contravariant with parameter \\$next \\(callable\\(Psr\\\\Http\\\\Message\\\\RequestInterface\\)\\: Http\\\\Promise\\\\Promise\\) of method Http\\\\Client\\\\Common\\\\Plugin\\:\\:handleRequest\\(\\)$#"
count: 1
path: src/Client/Http/LoggerPlugin.php

-
message: "#^Parameter \\#3 \\$first \\(callable\\(Psr\\\\Http\\\\Message\\\\RequestInterface\\)\\: Http\\\\Promise\\\\Promise\\<Psr\\\\Http\\\\Message\\\\ResponseInterface\\>\\) of method SimPod\\\\ClickHouseClient\\\\Client\\\\Http\\\\LoggerPlugin\\:\\:handleRequest\\(\\) should be contravariant with parameter \\$first \\(callable\\(Psr\\\\Http\\\\Message\\\\RequestInterface\\)\\: Http\\\\Promise\\\\Promise\\) of method Http\\\\Client\\\\Common\\\\Plugin\\:\\:handleRequest\\(\\)$#"
count: 1
path: src/Client/Http/LoggerPlugin.php

-
message: "#^Constructor of class SimPod\\\\ClickHouseClient\\\\Output\\\\Null_ has an unused parameter \\$_\\.$#"
count: 1
Expand Down
8 changes: 0 additions & 8 deletions src/Client/Http/LoggerPlugin.php
Expand Up @@ -19,14 +19,6 @@ public function __construct(private SqlLogger $logger)
{
}

/**
* @see RequestInterface
*
* @param callable(RequestInterface): Promise<ResponseInterface> $next
* @param callable(RequestInterface): Promise<ResponseInterface> $first
*
* @return Promise<ResponseInterface>
*/
public function handleRequest(RequestInterface $request, callable $next, callable $first): Promise
{
$id = uniqid('', true);
Expand Down

0 comments on commit bafdbbf

Please sign in to comment.