Escape backslash while replacing query parameters

simPod · Oct 8, 2020 · e9c14c5 · e9c14c5
1 parent de7032c
commit e9c14c5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Sql/SqlFactory.php b/src/Sql/SqlFactory.php
@@ -6,6 +6,7 @@
 
 use function preg_replace;
 use function Safe\sprintf;
+use function str_replace;
 
 /** @internal */
 final class SqlFactory
@@ -22,7 +23,11 @@ public function createWithParameters(string $query, array $parameters) : string
     {
         /** @var mixed $value */
         foreach ($parameters as $name => $value) {
-            $query = preg_replace(sprintf('~:%s(?!\w)~', $name), $this->valueFormatter->format($value, $name, $query), $query);
+            $query = preg_replace(
+                sprintf('~:%s(?!\w)~', $name),
+                str_replace('\\', '\\\\', $this->valueFormatter->format($value, $name, $query)),
+                $query
+            );
         }
 
         return $query;

diff --git a/tests/Sql/SqlFactoryTest.php b/tests/Sql/SqlFactoryTest.php
@@ -4,6 +4,7 @@
 
 namespace SimPod\ClickHouseClient\Tests\Sql;
 
+use SimPod\ClickHouseClient\Sql\Expression;
 use SimPod\ClickHouseClient\Sql\SqlFactory;
 use SimPod\ClickHouseClient\Sql\ValueFormatter;
 use SimPod\ClickHouseClient\Tests\TestCaseBase;
@@ -58,5 +59,17 @@ public function providerCreateWithParameters() : iterable
                 'pingpong' => 2,
             ],
         ];
+
+        yield 'escape backslash' => [
+            <<<CLICKHOUSE
+SELECT toIPv6('x\\\\')
+CLICKHOUSE,
+            <<<CLICKHOUSE
+SELECT :ping
+CLICKHOUSE,
+            [
+                'ping' => Expression::new("toIPv6('x\\\\')"),
+            ],
+        ];
     }
 }