refactor: remove store dependency in component unit test #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icepeng
force-pushed
the
refactor-test
branch
from
e803213
to
d26b705
Compare
oleneyl
reviewed
Dec 29, 2022
simaple/simulate/component/base.py
Outdated
Comment on lines
26
to
29
| def deepcopy(self: T) -> T: | ||
| values = dict(self._iter()) | ||
| fields_set = set(self.__fields_set__) | ||
| return self._copy_and_set_values(values, fields_set, deep=True) |
There was a problem hiding this comment.
question: 이거 구현을 이렇게 해야 하나보네요?
There was a problem hiding this comment.
이거 반환 타입이 Unknown으로 잡히고 있었네요;; 수정했습니다.
icepeng
force-pushed
the
refactor-test
branch
from
c4522f6
to
b096d1a
Compare
icepeng
force-pushed
the
refactor-test
branch
from
b096d1a
to
7693cb4
Compare
oleneyl
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ADR for more context.