Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ready for null safety #75

Merged
merged 14 commits into from
Nov 24, 2020
Merged

Clean up ready for null safety #75

merged 14 commits into from
Nov 24, 2020

Conversation

timsneath
Copy link
Contributor

@timsneath timsneath commented Nov 13, 2020

This PR cleans up the codebase a little:

  • Upgrades to a newer version of pedantic, removes redundant rules, and fixes newly-added lints
  • Uses final where possible for performance
  • Fixes filename spelling nit (granulartity -> granularity)
  • Uncomments out test now that bug has been fixed, and remove unnecessary test pump
  • Takes advantage of Dart int-to-double inference for fonts and pixel padding

Assuming you're happy to merge this pull request, I have a second one that builds on it and adds support for sound null safety:
https://github.com/timsneath/auto_size_text/pull/1

@simc
Copy link
Owner

simc commented Nov 24, 2020

Great, thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants