-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add textBuilder param #85
Conversation
Would you be able to land this?? It's extremely non-invasive and a nice add. |
Yes looks good. Would you mind adding a small section to the readme? And maybe document the new property. Thanks :) |
Should be good to go |
I tweaked it a bit to include the size in the Style, and add the Data param for more flexible usage. |
Hi can we land this pretty-please!? Would love to remove this fork dep from my yaml file |
Bump? |
It's probably a better idea to create a dedicated widget for this purpose. TextFields have margin and padding that would result in incorrect font sizes. |
Not if you zero them out... which you would likely do in this use case. |
Also |
Here you can see we used it to do some quite advanced logic, it worked awesome. We switch between a regular Text and a TextField when the thing is tapped, and have styled the TextField to exactly match the padding you get with Text: |
@esDotDev That's really cool thanks for sharing. I started working on an |
Sounds cool! So that would really just focus on producing |
Yes exactly. It's mostly used as a common builder for all the other AutoSize widgets and it should communicate with the |
Adds ability to supply our own TextWidget.
Addresses: #84