Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need invoke method? #16

Closed
wurikiji opened this issue Dec 12, 2019 · 8 comments
Closed

Do we need invoke method? #16

wurikiji opened this issue Dec 12, 2019 · 8 comments

Comments

@wurikiji
Copy link
Contributor

Dart, basically, supports thecall() method for all Functions. So we can already use myFunction?.call(). In addition, call() method can take any number of arguments.

@wurikiji
Copy link
Contributor Author

This is implicitly documented on Callable Classes.

@simc
Copy link
Owner

simc commented Dec 12, 2019

Oh I didn't know that ^^
I'll deprecate and remove the invoke() method.

@wurikiji
Copy link
Contributor Author

wurikiji commented Dec 12, 2019

:) Because this package is getting popular if you write what I said to your README, it will be really helpful for others who also don't know about this. Thanks for your works on this package 😍
Close this whenever you want.

@shinayser
Copy link
Contributor

This package will be getting very popular now that 2.7 as hit stable for Flutter 😆

@simc
Copy link
Owner

simc commented Dec 12, 2019

Do you get code completion for the .call() method because I don't. Maybe that would be an argument against removing .invoke().

@shinayser
Copy link
Contributor

Do you get code completion for the .call() method because I don't. Maybe that would be an argument against removing .invoke().

None completion. But the completion on dart is really weird. I will post this issue on the language repo.

@shinayser
Copy link
Contributor

Done. Give it a thumbs up to help it enter on developers radar :)

dart-lang/sdk#39761

passsy added a commit that referenced this issue Jan 4, 2020
@passsy
Copy link
Collaborator

passsy commented Jan 4, 2020

The deprecation is a good solution!

@passsy passsy closed this as completed Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants