Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md - move CLMUL to partial, list more of the CI.yml architectures #1170

Merged
merged 2 commits into from Apr 1, 2024

Conversation

Torinde
Copy link
Contributor

@Torinde Torinde commented Mar 28, 2024

Per #1152 (comment)

Should the following two architectures also be added?

  • ARMv8 SVE - it's in simde-features.h, but I couldn't find it in ci.yml
  • z/Architecture ZVECTOR - it's in simde-features.h, but ci.yml just lists s390x, so unclear if ZVECTOR extensions are utilized

@mr-c
Copy link
Collaborator

mr-c commented Mar 28, 2024

That's correct, it isn't currently under any test

  • z/Architecture ZVECTOR - it's in simde-features.h, but ci.yml just lists s390x, so unclear if ZVECTOR extensions are utilized

Looking at .github/workflows/ci.yml

- version: 12
cross: s390x
arch_gnu: s390x
arch_deb: s390x

which gets combined with

run: meson setup --cross-file=docker/cross-files/${{ matrix.cross }}-gcc-${{ matrix.version }}${{ matrix.extra}}-ccache.cross build

Therefore we check https://github.com/simd-everywhere/simde/blob/master/docker/cross-files/s390x-gcc-12-ccache.cross and find

c_args = ['-march=z13', '-mzvector', '-Wextra', '-Werror']
cpp_args = ['-march=z13', '-mzvector', '-Wextra', '-Werror']

So yes, s390x with zvector is tested in CI ; woohoo!

@Torinde
Copy link
Contributor Author

Torinde commented Mar 28, 2024

Great. Can you please add "ZVECTOR" to the z/Architecture line - before merging?

@mr-c mr-c enabled auto-merge (rebase) March 29, 2024 11:51
@mr-c mr-c disabled auto-merge April 1, 2024 12:24
@mr-c mr-c merged commit 8639fef into simd-everywhere:master Apr 1, 2024
86 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants