Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm: enable more intrinsic function for armv7 #1172

Merged

Conversation

zengdage
Copy link
Contributor

Hi, I run the arm-neon-tests (https://github.com/christophe-lyon/arm-neon-tests) for simde neon2rvv, and have set the flags -DSIMDE_RISCV_V_NATIVE -DSIMDE_ARM_NEON_A32V7_ENABLE_NATIVE_ALIASES to compiler. But I get some compiler reported errors as follow, it means that vld4_s6 is not supported in simde neon2rvv.

ref_vldX.c:200:3: error: call to undeclared function 'vld4_s64'; ISO C99 and later do not support implicit function declarations 

As I know,vld4_s64 and the other intrinsic function which are mentioned in my patch are supported in armv7 platform. But simde disable them in armv7 platform. So I upload the patch to enable those intrinsic function in armv7 platform. Please help to review, thanks.

Copy link
Collaborator

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @zengdage and thank you for running that test and for this contribution. I have one suggestion that needs addressing before merging.

simde/arm/neon/ld2_lane.h Outdated Show resolved Hide resolved
Signed-off-by: Zhijin Zeng <zhijin.zeng@spacemit.com>
@zengdage zengdage force-pushed the enable_more_intrinsic_function_v7 branch from 3837fe8 to 453ba23 Compare April 12, 2024 09:40
@mr-c mr-c enabled auto-merge (rebase) April 12, 2024 09:48
@mr-c mr-c merged commit 416091e into simd-everywhere:master Apr 12, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants