Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings with -fno-lax-vector-conversions #899

Merged
merged 1 commit into from Aug 13, 2021
Merged

Fix warnings with -fno-lax-vector-conversions #899

merged 1 commit into from Aug 13, 2021

Conversation

ngzhian
Copy link
Collaborator

@ngzhian ngzhian commented Aug 12, 2021

Fix #898.

@nemequ
Copy link
Member

nemequ commented Aug 13, 2021

Nice, thanks!

I think it would also be a good idea to add this flag to the clang builds on CI; TBH I thought -Weverything covered it, but I guess not ☹. I'll try to add a patch for that soon.

@nemequ nemequ merged commit e5ff228 into simd-everywhere:master Aug 13, 2021
@ngzhian ngzhian deleted the reinterp-cast branch August 13, 2021 20:55
@ngzhian
Copy link
Collaborator Author

ngzhian commented Aug 13, 2021

I am surprised -Weverything doesn't cover it, but maybe this flag doesn't count as a diagnostic under W (since it begins with -f)? Another reason might be https://bugs.llvm.org/show_bug.cgi?id=17164#c15 this cannot be turned on since it breaks clang, so maybe that's why it's not included in -Weverything.

@ngzhian
Copy link
Collaborator Author

ngzhian commented Aug 13, 2021

Btw, tried adding "'-fno-lax-vector-conversions', '-Wno-c++11-narrowing'" to emscripten.cross, lots of errors :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile failures with -fno-lax-vector-conversions
2 participants
@ngzhian @nemequ