Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slowdown during switch from 3.1.8 to 3.2.0 version #2028

Closed
slidertom opened this issue Jul 6, 2023 · 4 comments · Fixed by #2029
Closed

slowdown during switch from 3.1.8 to 3.2.0 version #2028

slidertom opened this issue Jul 6, 2023 · 4 comments · Fixed by #2029

Comments

@slidertom
Copy link

slidertom commented Jul 6, 2023

Hi,
I get slowdown after version upgrade from 3.1.8 till 3.2.0.
Mine custom tests: (json parse time it's only about 50%)
3.2.0: 66.745324 s
3.1.8: 45.268451 s
(I simply change cpp/h simdjson files)

simdjson::ondemand
const size_t len = json.length();
doc = parser.iterate(json.c_str(), len, len + simdjson::SIMDJSON_PADDING);

Visual Studio 17.6.4
64 bit

Maybe some new define is introduced?
https://github.com/simdjson/simdjson/releases/tag/v3.2.0

Maybe some pipelines can be found to detect, that new versions produces similar results?
(maybe it's simply duplicate of #1687)

@lemire
Copy link
Member

lemire commented Jul 7, 2023

Yes. The problem is with #2004

lemire pushed a commit that referenced this issue Jul 7, 2023
lemire added a commit that referenced this issue Jul 7, 2023
* Undoing PR 2004 due to performance concerns.

Fixes #2028
Fixes #2021

* Adding final lines.

---------

Co-authored-by: Daniel Lemire <dlemire@lemire.me>
@lemire
Copy link
Member

lemire commented Jul 7, 2023

@slidertom Please verify. The issue should be fixed in the latest release.

@slidertom
Copy link
Author

Yes, the issue is fixed in the latest release and 3.2.1 version works even faster vs. 3.1.8.
Thank you!

@lemire
Copy link
Member

lemire commented Jul 7, 2023

Thanks for confirming the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants