Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix several typos #1558

Merged
merged 3 commits into from May 1, 2021
Merged

fix several typos #1558

merged 3 commits into from May 1, 2021

Conversation

striezel
Copy link
Contributor

@striezel striezel commented May 1, 2021

Fixes typos in documentation / comments.

@striezel
Copy link
Contributor Author

striezel commented May 1, 2021

Some of the Ubuntu builds failed with the following error:

[100%] Built target checkperf
Test project /home/runner/work/simdjson/simdjson/build
    Start 86: checkperf
1/1 Test #86: checkperf ........................***Failed    0.28 sec
Attempt #1 of 7
/home/runner/work/simdjson/simdjson/build/benchmark/dom/parse -H -t /home/runner/work/simdjson/simdjson/build/jsonexamples/twitter.json
perf_event_open: Permission denied
[                                                  ]���������������������������������������������������=��                                                     �����������������������������������������������������New throughput: 1.8294
/home/runner/work/simdjson/simdjson/build/benchmark/dom/checkperf-reference/master/build/benchmark/parse -H -t /home/runner/work/simdjson/simdjson/build/jsonexamples/twitter.json
sh: 1: /home/runner/work/simdjson/simdjson/build/benchmark/dom/checkperf-reference/master/build/benchmark/parse: not found
Error 32512 running benchmark command!


Errors while running CTest
0% tests passed, 1 tests failed out of 1

Label Time Summary:
explicitonly          =   0.28 sec*proc (1 test)
per_implementation    =   0.28 sec*proc (1 test)

Total Test time (real) =   0.32 sec

The following tests FAILED:
	 86 - checkperf (Failed)
Error: Process completed with exit code 8.

I am not sure why that happens, but it seems the current master commit 85b910814eff8c21ccd055e4136b2931d9211d41 has the same problem with those two checks failing there, too. (See https://github.com/simdjson/simdjson/runs/2479665990 and https://github.com/simdjson/simdjson/runs/2479666044.) Therefore I assume it is not caused by some kind of regression introduced by this pull request.

@lemire
Copy link
Member

lemire commented May 1, 2021

I am happy to merge this. I will have a quick look at the perf check routine. It broke following another PR being merged.

@lemire lemire merged commit 2abcc35 into simdjson:master May 1, 2021
@lemire
Copy link
Member

lemire commented May 1, 2021

Merged.

@striezel striezel deleted the typos branch May 2, 2021 07:53
@striezel striezel changed the title fix serveral typos fix several typos Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants