Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more development checks to the DOM front-end #1915

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Adding more development checks to the DOM front-end #1915

merged 3 commits into from
Oct 17, 2022

Conversation

lemire
Copy link
Member

@lemire lemire commented Oct 16, 2022

In debug mode, this adds some checks to help DOM users who rely on unsafe patterns.

Fixes #1914

TysonAndre
TysonAndre reviewed Oct 16, 2022
View reviewed changes
Copy link
Contributor

@TysonAndre TysonAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This should be rebased

Some optional nits but those are just personal preferences

The implementation looks good to me

include/simdjson/dom/array-inl.h Outdated Show resolved Hide resolved
doc/dom.md Outdated Show resolved Hide resolved
@lemire lemire merged commit a5db75e into master Oct 17, 2022
@lemire lemire deleted the dlemire/issue1914 branch October 17, 2022 13:11
@FourierTransformer FourierTransformer mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TysonAndre TysonAndre TysonAndre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default constructed array should handle end() properly
2 participants
@lemire @TysonAndre