Adding support for wobbly strings to On Demand and lossy trancoding from escaped (with replacement) #1947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users receive strings that cannot be decoded into valid UTF-8 due to a bad sequence of escaped code points. A reasonable solution is to fallback on WTF-8. This is allowed by RFC...
Note that the original input must still be UTF-8. And we will continue to validate for UTF-8 by default. Users will need to call a specific function (get_wobbly_string()).
We also adding a Boolean parameter to our
get_string()
methods so that replacement characters are inserted in lieu of errors (lossy decoding).The DOM kernel will not be affected.
Fixes #1944