Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing a variable to the structural indexer step #2055

Conversation

lemire
Copy link
Member

@lemire lemire commented Aug 25, 2023

PR for #2052

It allows scripts such as...

for i in {1..10}; do
    echo "Setting  SIMDJSON_STRUCTURAL_INDEXER_STEP to $i "
    cmake -B build -D SIMDJSON_STRUCTURAL_INDEXER_STEP=$i -D SIMDJSON_DEVELOPER_MODE=ON >> /dev/null
    cmake --build build --target parse  >> /dev/null
    sudo ./build/benchmark/dom/parse -s stage1 -n 3000 jsonexamples/twitter.json
    sudo ./build/benchmark/dom/parse -s stage1 -n 3000 jsonexamples/twitter.json
    sudo ./build/benchmark/dom/parse -s stage1 -n 3000 jsonexamples/twitter.json
done

@lemire lemire requested a review from jkeiser August 25, 2023 16:20
Copy link
Member

@jkeiser jkeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@lemire lemire merged commit c969200 into jkeiser/structural_indexer_step Aug 25, 2023
64 checks passed
@lemire lemire deleted the dlemire/allow_SIMDJSON_STRUCTURAL_INDEXER_STEP branch August 25, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants