Allowing users to write directly to std::optional<std::string>

[lemire]

  auto json = R"({ "foo1": "3.1416" } )"_padded;
  ondemand::parser parser;
  ondemand::document doc = parser.iterate(json);
  std::optional<std::string> value;
  if(doc["foo1"].get_string(value)) { /* error */ }

[anonrig]

Does it make sense to add std::optionalstd::string_view support as well?

[lemire]

Does it make sense to add std::optional<std::string_view> support as well?

With my latest commits, it would, but an std::string_view does not own its content. In simdjson, it can point at the original JSON, or at a buffer hidden inside the parser instance. In the cases that we care about, it is going to live inside the parser instance I think. So you have to be mindful of the lifespan of the data. That is, you should keep both the std::optional<std::string_view> and the parser instances alive.