fix typo

[void-mian]

Some typos in comments.

[void-mian]

BTW, Can't I rely on these api? I see it's marked as private.

[lemire]

Merging.

[lemire]

Can't I rely on these api? I see it's marked as private.

What is your use case? These functions are meant for internal use. I am not sure how a user of the library would ever need them...

[void-mian]

I've created a helper function that returns simdjson_result as the result. But I ended up using optional instead, because I noticed the error code was unreliable.

[lemire]

The error code should not be unreliable. Can you give me an example with code?

[void-mian]

Sorry for the misunderstanding. I mean it's unstable, the doc says the error code may be changed. And here a example:

simdjson::simdjson_result<int> count_key_recursively(simdjson::ondemand::value& value, const std::string_view& key) {
    simdjson::error_code ec;
    simdjson::ondemand::object temp;
    if (value.get_object().get(temp)) {
        return ec;
    }
    // iterate the json recursively...
}

Since I don't need the error code here, I replace it with std::optional to indicate whether a parser error has occurred.

[lemire]

In that code, ec is never initialized, right?

Do you mean to write…

if(error_code ec = value.get_object().get(temp); ec) {
  return ec;
}

[void-mian]

Yes, forgot to assign the error code.