Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull size_t from the std namespace #2191

Merged
merged 1 commit into from
Jun 3, 2024
Merged

pull size_t from the std namespace #2191

merged 1 commit into from
Jun 3, 2024

Conversation

qbojj
Copy link
Contributor

@qbojj qbojj commented May 31, 2024

Fix #2190

I have decided to use std::size_t in nonstd/string_view.hpp as there were already parts where it was used

@lemire
Copy link
Member

lemire commented May 31, 2024

Please do not modify the string_view code. It is not simdjson code, it is merely bundled for convenience. If you have concerns about about the string_view implementation, please first take it with @martinmoene as we are not going to manually modify their code:
https://github.com/martinmoene/string-view-lite

@qbojj
Copy link
Contributor Author

qbojj commented Jun 3, 2024

I have reverted the changes to string_view

@lemire
Copy link
Member

lemire commented Jun 3, 2024

Running tests.

@lemire
Copy link
Member

lemire commented Jun 3, 2024

Merging.

@lemire lemire merged commit 3964f3e into simdjson:master Jun 3, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use of size_t but including <cstddef>
2 participants