Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @OMaghiarIMGs comment, I looked over the rvv utf8 validation code again, and found a bug in it.
The ASCII fast path must make sure that the next three bytes are valid.
An easy way to do that is to check if they are also ASCII, this is what this patch does.
An alternative would be to subtract three from
vl
, but then you would need to avoid the possibility of such code turning into an infinite loop, whenvl<=3
. The first fix seemed more straight forward.I also cleaned up the
tail
variable. It was used for three separate things, and two of those could've used a smaller value.