tests: use ASSERT_EQUAL where applicable #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemire
reviewed
Apr 8, 2024
lemire
reviewed
Apr 8, 2024
|
@WojciechMula This fails under Visual Studio. Can you check my proposals? |
WojciechMula
force-pushed
the
tests-use-assert-eq
branch
from
f244aeb
to
2a4bc6d
Compare
|
@lemire thank you, applied your suggestions, let's wait for CI outcome |
lemire
reviewed
Apr 9, 2024
|
@WojciechMula There are two remaining cases. |
|
@WojciechMula I tried some fixes let us see what the tests say. |
lemire
reviewed
Apr 10, 2024
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.