Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: factor out looping into macro #398

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

WojciechMula
Copy link
Collaborator

Also fix some cases where random generator was not re-seeded in new trials.

@lemire
Copy link
Member

lemire commented Apr 8, 2024

@WojciechMula I am investigating the failures.

@lemire
Copy link
Member

lemire commented Apr 8, 2024

@WojciechMula I think that you have exposed a bug in our test framework. It is fixed by this PR #399

@lemire
Copy link
Member

lemire commented Apr 9, 2024

@WojciechMula Can you rebase on our main branch? I merged #399

It should solve these issues, hopefully.

Also fix some cases where random generator was not re-seeded in new trials.
@lemire
Copy link
Member

lemire commented Apr 9, 2024

Merging.

@lemire lemire merged commit c9e9d51 into simdutf:master Apr 9, 2024
44 checks passed
@WojciechMula WojciechMula deleted the tests-loop-macros branch April 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants