Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timing between characters and words. #6

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Fix timing between characters and words. #6

merged 2 commits into from
Feb 25, 2022

Conversation

evan-brass
Copy link
Collaborator

The old timing was 5 units between letters and I think 13 units between words.
The corrected timing is 3 units between letters and 7 units between words.

I remember thinking a lot about this and I still messed it up, oops.

@vercel
Copy link

vercel bot commented Feb 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

morse-transmitter – ./

🔍 Inspect: https://vercel.com/sime/morse-transmitter/B2QVv2FrEPE92PLbiAUjDesGCa1A
✅ Preview: https://morse-transmitter-git-morse-code-timing-sime.vercel.app

Copy link
Owner

@sime sime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values should be defined as constants somewhere early in the code. Otherwise they are magic numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants