Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comparableKey should be an internal API #197

Closed
simerplaha opened this issue Feb 17, 2020 · 1 comment
Closed

comparableKey should be an internal API #197

simerplaha opened this issue Feb 17, 2020 · 1 comment
Labels
Improvement

Comments

@simerplaha
Copy link
Owner

simerplaha commented Feb 17, 2020 •
edited

comparableKey in KeyOrder adds bit of complexity to the key ordering API which should be removed and restricted to internal use only. If the functionality of comparableKey is required (I'm guessing rarely) then the simpler MapSet type should be used.
simerplaha added a commit that referenced this issue Feb 18, 2020
@simerplaha
reverted #197
f41e0d8
@simerplaha
Copy link
Owner Author

Reverted this but instead made comparableKey an Optional extension. It's not required if the keys submitted are not partial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simerplaha