Feature/metrics enable flag #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cregev
requested changes
Jul 15, 2020
collector/metrics.go
Outdated
| log "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| // ErrResourceNotConfigure defines the error when the resource not configure |
There was a problem hiding this comment.
not configure -> is not configured.
collector/metrics.go
Outdated
| return metricsResponse, ErrResourceNotConfigure | ||
| } | ||
|
|
||
| // loop on resource metrics and extract only the enable metrics |
collector/metrics.go
Outdated
| return metricsResponse, nil | ||
| } | ||
|
|
||
| // IsResourceEnable checks if the resource configure and enabled |
collector/metrics.go
Outdated
| } | ||
|
|
||
| if !resource.Enable { | ||
| logger.Info("resource has not enable metrics") |
There was a problem hiding this comment.
has not enable --> has not enabled
cregev
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/Feature
What this PR does / why we need it:
Add the option to enable/disable resource detection according to collector's configuration
Which issue(s) this PR fixes (if exists):
Fixes #94