Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tests improve docdb #110

Merged
merged 4 commits into from
Jul 26, 2020
Merged

Feature/tests improve docdb #110

merged 4 commits into from
Jul 26, 2020

Conversation

kaplanelad
Copy link
Contributor

What type of PR is this?
/tests

What this PR does / why we need it:
Improve document DB tests

@kaplanelad kaplanelad added the kind/new-feature New feature label Jul 22, 2020
@kaplanelad kaplanelad requested a review from ortz July 22, 2020 12:58
@kaplanelad kaplanelad self-assigned this Jul 22, 2020
ortz
ortz suggested changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@ortz ortz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments that we discussed about

@kaplanelad kaplanelad requested a review from ortz July 23, 2020 16:08
@kaplanelad
Copy link
Contributor Author

Hey @ortz,
i have fixed/replay your comments.

@kaplanelad kaplanelad merged commit 7882a97 into master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ortz ortz ortz approved these changes

Assignees

@kaplanelad kaplanelad

Labels
kind/new-feature New feature lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaplanelad @ortz