Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/es testing #138

Merged
merged 6 commits into from
Sep 6, 2020
Merged

Feature/es testing #138

merged 6 commits into from
Sep 6, 2020

Conversation

kaplanelad
Copy link
Contributor

What type of PR is this?
/Maintenance

What this PR does / why we need it:
Add unitesting to elasticsearch package storage

Which issue(s) this PR fixes (if exists):

Fixes #135

@kaplanelad kaplanelad added the area/api Improvements or additions to API label Aug 19, 2020
@kaplanelad kaplanelad requested a review from cregev August 19, 2020 16:57
@kaplanelad kaplanelad self-assigned this Aug 19, 2020
@kaplanelad kaplanelad added the kind/tests Add Tests label Aug 19, 2020
@kaplanelad kaplanelad added this to In progress in v0.4.0 via automation Aug 19, 2020
@kaplanelad kaplanelad removed this from In progress in v0.4.0 Aug 19, 2020
api/storage/elasticsearch/client.go Outdated Show resolved Hide resolved
api/storage/elasticsearch/client.go Outdated Show resolved Hide resolved
api/storage/elasticsearch/elasticsearch.go Outdated Show resolved Hide resolved
api/storage/elasticsearch/elasticsearch.go Outdated Show resolved Hide resolved
api/storage/elasticsearch/testutils/client.go Outdated Show resolved Hide resolved
@cregev cregev added the lgtm label Sep 1, 2020
@kaplanelad kaplanelad merged commit 2db2d5b into master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Improvements or additions to API kind/tests Add Tests lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Storage tests
2 participants