Feature/aws profile auth #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaplanelad
added
kind/new-feature
cregev
requested changes
Aug 22, 2020
collector/aws/auth.go
Outdated
| log.WithField("region", region).Info("auth: using aws profile") | ||
| config := &awsClient.Config{ | ||
| Region: ®ion, | ||
| Credentials: credentials.NewSharedCredentials("", profile), |
There was a problem hiding this comment.
Why don't you give the option to pass custom Profile file ?
configuration/collector.yaml
Outdated
| @@ -12,6 +12,7 @@ providers: | |||
| # access_key: <access_key> | |||
| # secret_key: <secret_key> | |||
| # role: | |||
There was a problem hiding this comment.
Don't we want to order the types of login like the code expects them ( hierarchy)
collector/aws/detector.go
Outdated
| @@ -32,6 +32,7 @@ const ( | |||
|
|
|||
| // DetectorManager describe tje detector manager | |||
| type DetectorManager struct { | |||
| awsAuth AuthDescriptor | |||
collector/aws/detector.go
Outdated
| cloudWatchCLient := cloudwatch.NewCloudWatchManager(awsCloudwatch.New(regionSession, regionConfig)) | ||
|
|
||
| callerIdentityOutput, _ := stsManager.client.GetCallerIdentity(&sts.GetCallerIdentityInput{}) | ||
| return &DetectorManager{ | ||
| awsAuth: awsAuth, |
There was a problem hiding this comment.
Why do you need it ? I don't see any reference for using this type.
cregev
approved these changes
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/Feature
What this PR does / why we need it:
Allow authenticate to aws with multiple profiles
Which issue(s) this PR fixes (if exists):
Fixes #80
Special notes for your reviewer:
I have reordered the AWS auth logic